The NRA’s membership dues and political spending has not been immune to the broader challenges faced by the leading gun-rights organization.